I'll handle the design pass on this one today.

Given that this exacerbates #2626, are we comfortable shipping this without a fix for that?

Given that this exacerbates #2626, are we comfortable shipping this without a fix for that?

I think it's a separate PR.

I agree with Dave - probably best to keep that as a separate PR to keep the overall diff size down, and there's some extra questions&decisions to be had first which are separate from the control column stuff.

OK @chandlerprall. I fixed the styling issues and cleaned up the docs example to be a little more polished. Some things I did:

1. I moved the position of additionalControls to the front. I think this makes the most sense from a usage perspective in almost all cases. It's a non-breaking change.
2. I made it so that control columns don't truncate. Since they require width and should be used for known width elements, I think this is OK. The major benefit here is that it fixes all the focus states (which use outlines and sat outside the overflows).
3. I adjusted the docs example to give a more designy pattern for how we'd want people to utilize these controls.

As part of this I had to navigate your code a bit and found it easy enough to read. Only comment is that some of it's a little repetitive, but I prefer that to heavy abstraction since this component is already tricky enough.

One feature request (only if easy). I'd prefer that we could pass arbitrary selectors onto the row itself. Similar to setCellProps. That would give us a better way to handle things like highlighting. The example you set up with theming isn't likely something we'd want to do on the design side, and I'd probably prefer not giving people bad ideas in the docs.

@snide Quick design question. This pattern with using the triple dot icon before a link is new and not really how we've used that icon before.

Thoughts on why using that instead of our typical down arrow to the right of the link to indicate popovers?

Thoughts on why using that instead of our typical down arrow to the right of the link to indicate popovers?

No good reason. This isn't baked into the component itself, just the docs. I started with the arrow, but then noticed we were using the dots on the right side so I figured I'd try it out. Likely a bad idea. I'll add the arrow back in.

Prolly needs a screen for that comment to make sense.

One feature request (only if easy). I'd prefer that we could pass arbitrary selectors onto the row itself. Similar to setCellProps. That would give us a better way to handle things like highlighting. The example you set up with theming isn't likely something we'd want to do on the design side, and I'd probably prefer not giving people bad ideas in the docs.

Thinking through this, and trying some ideas out.

Added a flyout example to the docs, which effectively answers the needs of #2462